Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kitsu Task type and status sync + tests #81

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

johhnry
Copy link

@johhnry johhnry commented Oct 21, 2024

Changelog Description

This PR mainly solves #72

  • Fixed the short_name key to shortName
  • Added the default icon task_alt for both task type and status
  • Re ran unit tests and fixed database changes (new scope field in status, priority field on tasks)
  • Use Poetry's new dependency groups for unit tests
  • Use package-mode = false for unit tests because we don't need to treat the code as a package
  • Fix codenamize dependency which was version ^1.2.4-dev.1 and didn't exist on Pip
  • Add missing httpx dependency

Testing notes:

  1. Create a new task type in Kitsu
  2. Add it to your project
  3. Create that task on an asset/shot
  4. Make sure that you can browse the folders in the Launcher without errors and that it has the proper icon and shortName fields
  5. You can do the same with task statuses

@BigRoy BigRoy requested a review from iLLiCiTiT October 21, 2024 09:38
@BigRoy BigRoy added the type: bug Something isn't working label Oct 21, 2024
@BigRoy BigRoy requested a review from martastain October 21, 2024 09:42
@BigRoy BigRoy requested a review from m-u-r-p-h-y October 21, 2024 09:43
@BigRoy BigRoy added the community Issues and PRs coming from the community members label Oct 21, 2024
@martastain martastain merged commit 1ba1fd5 into ynput:develop Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants