-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status change on user action #73
base: develop
Are you sure you want to change the base?
Conversation
I have doubts about code style and some decisions i've made to make it work, bot it works now help me please to make code and logic pretty please) Hope you like it! |
could you create an issue for your enhancement request/suggestion and link it to this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test run the PR yet.
I'd recommend adding settings in multiple places. so that we have them near to each other so that we know that these settings belongs to the same feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timsergeeff could you please install a linter for your IDE that matches the code style of the repo, mostly PEP08. There's a lot of invalid blank lines.
Also, a spell-checker may also help since the log messages contain typos.
Co-authored-by: Mustafa Jafar <[email protected]>
Co-authored-by: Mustafa Jafar <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Mustafa Jafar <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Mustafa Jafar <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
@MustafaJafar i think i cant connect pr with issue because of rules of repo |
Hello there. First, many thanks @timsergeeff for sharing your work 🙏😍 !!! I like the goal of it, and it aligns with some of the ability we want to offer in AYON. To achieve this, the implementation should only deal with AYON statuses, and the propagation to Kitsu and other production trackers should be handled transparently by their synchronisation addons. There is very little chance we will merge this. But I'm pretty sure we can find a way to leverage your work and turn it into a contribution. What about transfering this to a dedicated addon of yours, which would affect AYON statuses instead of kitsu. And we'd take care of the synchronisation between AYON and kitsu, updating ayon-kitsu as needed. FYI, there are similar explorations going on from FTrack users, and we definitely will have something similar in AYON (and it's amazing to see the concept live before we do it <3) |
if not gazu.task.get_task_status_by_short_name(self.app_start_status_shortname): | ||
self.log.info("Failed to recieve kitsu status instance for shortname. Skipping Status change.") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A “line too long” happens when the number of the characters per line exceeds the maximum number specified in repo.
Line 33 in 98266f8
line-length = 79 |
personally, I prefer to have some display in my IDE to tell me the number of characters in my line.
Fixes are mostly like
if not gazu.task.get_task_status_by_short_name(self.app_start_status_shortname): | |
self.log.info("Failed to recieve kitsu status instance for shortname. Skipping Status change.") | |
return | |
if not gazu.task.get_task_status_by_short_name( | |
self.app_start_status_shortname | |
): | |
self.log.info( | |
"Failed to recieve kitsu status instance for shortname." | |
" Skipping Status change." | |
) | |
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also even better - if you setup strict linter rules in an IDE (code editor) you can have it auto-correct the formatting for you. That way you don't need to do this manually.
App start status change
Now we have ability to change status on users starting app action.
Pause other tasks with WIP status
We can turn off pausing all other WIP tasks. This logic made of state: only one task can be WIP at a time.
Farm render status change
Previosly task was getting status change (WFA) only at publishing state in deadline so in between of publishing job to farm and publishing to kitsu we have nothing indicating current task status. Now we have FARM status change when farm rendering is on
Additional info
The settings allow to configure status change conditions so statuses will not double. And some other changes to settings needed to be done to make all logic work and ahve opportunity to swith in on or off
Testing notes: