Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: subtract 1 in end frame calculation #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix: subtract 1 in end frame calculation #86

wants to merge 1 commit into from

Conversation

johhnry
Copy link

@johhnry johhnry commented Oct 24, 2024

Changelog Description

This PR fixes #85

Additional info

The feature was fixed here but removed here.

Testing notes:

  1. Change in/nb_frames in Kitsu for a shot
  2. Check that the values for start/end frames are correct in AYON

@MustafaJafar MustafaJafar added community Issues and PRs coming from the community members type: bug Something isn't working labels Nov 1, 2024
@MustafaJafar
Copy link
Contributor

I wonder if test_push_update.py::test_calculate_frames that was referred to in #59 is wrong.

@johhnry
Copy link
Author

johhnry commented Nov 12, 2024

@MustafaJafar You mean that the test is actually wrong? (and so the fix that let it pass is wrong to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect calculation for end frame with nb_frames
2 participants
@johhnry @MustafaJafar