Add documentation for webactions and enhance production tracker docs #287
Conversation
| entity_type="folder", | ||
| entity_subtypes=None, |
There was a problem hiding this comment.
I recall - as I tried to implement these - being quite confused about what combinations of values this support. Should we document that clearer somewhere (either in the code somewhere, or here?)
There was a problem hiding this comment.
@martastain
TL;DR
This PR adds draft/initial docs for implementing web actions. Also, I've added an example web action.
My question: Do you have any recommendations for extending the current initial docs?
There was a problem hiding this comment.
I'm personally fine with it staying as is - just saying that it'd be nice to get this clarified over time because it's where I got lost.
|
@MustafaJafar this is never going to get approved by everyone, probably better to merge now and improve later? |
yeah, let's merge it. |
|  | ||
|
|
||
| ```python title="my_addon/client/my_addon/__init__.py" | ||
| from qtpy import QtWidgets |
There was a problem hiding this comment.
It's too late, but Qt (or any other runtime dependency) should never be imported in addon...
There was a problem hiding this comment.
This is not the only example that imports QT in addon 😅
e.g. I did the same in the tray example
For reference, should it be imported inside the function like here?
There was a problem hiding this comment.
For reference, should it be imported inside the function like here?
Yes, usually by importing Qt it in the function, or by importing file that has Qt implementation inside the function.
Changelog Description
resolve #252
This PR adds:
Testing notes: