Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications: New settings #220

Merged
merged 26 commits into from
Sep 12, 2024
Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Added information about new settings introduced in applications addon.

Additional info

Note: The 1.0.0 release is not yet out, should we wait for the release and then merge, or merge and then release?

website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
Co-authored-by: Roy Nieterau <[email protected]>
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I did have two cosmetic notes that would be nice to include.

website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
@MustafaJafar MustafaJafar requested a review from BigRoy August 30, 2024 15:35
@MustafaJafar
Copy link
Contributor

MustafaJafar commented Aug 30, 2024

@BigRoy @iLLiCiTiT Sorry for my mega commit.
I've updated the main structure of the page, and there should be some upcoming commits to tweak the wording and the info in the page.

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @MustafaJafar - some remarks.

Also, you seem to space out the question mark with a space at the end of the sentence?

So you do:

  • this ?
  • instead of this?

Which seems odd. As far as I know that's wrong in English, so would be good to correct.

website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added few commits and resolved previous conversations
But, I'm wondering about the following

website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
website/docs/addon_applications_admin.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in nuke supported versions | Ynput Forums

we should emphasize that we don't support apps with python 2.

@MustafaJafar MustafaJafar self-requested a review September 12, 2024 08:50
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready to merge.

@iLLiCiTiT iLLiCiTiT merged commit c082827 into main Sep 12, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/new-applications-settings branch September 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants