Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): adjust link class for better mobile support #192

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

gibsonliketheguitar
Copy link
Contributor

Changes

  • linkWarper contianer is not hidden when window is shrunk
  • link are displayed in column fashion in mobile view

Screenshot before changes

image

Screenshot after changes

image

image

@MustafaJafar MustafaJafar marked this pull request as draft July 15, 2024 17:05
@MustafaJafar MustafaJafar marked this pull request as ready for review July 15, 2024 17:05
@MustafaJafar MustafaJafar added the type: bug Something isn't working label Jul 15, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I gave it a test on my PC and on my phone.
It's better!
The main difference is on the main page.

Before After

Here's a recording
The current docs is first half of the recording and this PR is the second half.
https://drive.google.com/file/d/1YSKM1OsOH4riqcRa7X7Hzyc_jpcASEbu/view?usp=sharing

@Innders Innders merged commit 242b004 into ynput:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants