Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini:add product types table #163

Closed
wants to merge 3 commits into from

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Adding a list of stock product types that come with Ynput's Houdini addon.

Here's a preview:
image

@MustafaJafar
Copy link
Contributor Author

Hey @BigRoy ,
Do you have any opinion that you would like to share with us regarding this PR?

@MustafaJafar MustafaJafar requested a review from BigRoy April 30, 2024 14:12
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose having a list is helpful - whether we're able to keep it sync with the addon nicely and in a timely manner is hard to say.

Only thing that stood out to me is usage of PointCache instead of Pointcache - not sure if we need the uppercase C there.

Probably best left to someone else to approve it that can look at this from a higher POV. :)

@MustafaJafar
Copy link
Contributor Author

Only thing that stood out to me is usage of PointCache instead of Pointcache - not sure if we need the uppercase C there.

I copied pasted the label and product_type

https://github.com/ynput/ayon-core/blob/df976a4ab8900b14c70331519afd563e871c8d09/client/ayon_core/hosts/houdini/plugins/create/create_bgeo.py#L12-L13

whether we're able to keep it sync with the addon nicely and in a timely manner is hard to say.

That's a good question!

@MustafaJafar
Copy link
Contributor Author

mentioning @antirotor .. This PR is meant to align with ynput/ayon-core#9 to help admins know which values to use with which product types.

@mkolar
Copy link
Member

mkolar commented May 3, 2024

mentioning @antirotor .. This PR is meant to align with ynput/ayon-core#9 to help admins know which values to use with which product types.

I made a comment on the corresponding PR as well. I'm not sure this is that useful. We have a page with all the product types in the global docs section and then attributes on the addon in the docs that is visible here https://ayon.ynput.io/features?addons=houdini

update that, but don't add the same information into a new table

@MustafaJafar MustafaJafar marked this pull request as draft May 7, 2024 09:12
@MustafaJafar
Copy link
Contributor Author

This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants