Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: abc options for Pointcache/Animation family - OP-5920 #137

Merged
merged 4 commits into from
May 22, 2024
Merged

Maya: abc options for Pointcache/Animation family - OP-5920 #137

merged 4 commits into from
May 22, 2024

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Feb 20, 2024 •
edited
Loading

MustafaJafar
MustafaJafar reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize it's a draft 😅 until I opened Maya and didn't see these options 🤣

Here's how it looks like on the website.
image

@tokejepsen tokejepsen marked this pull request as ready for review May 3, 2024 11:43
@tokejepsen tokejepsen requested a review from MustafaJafar May 3, 2024 11:43
MustafaJafar
MustafaJafar approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good.

I have one question if you don't mind.
does the maya docs are aligned with the current maya addon version 0.1.17

https://github.com/ynput/ayon-core/blob/61ca9f68f34c27d4ff677b002ba71379bef3ab8a/server_addon/maya/package.py#L3

because the current badge value is 0.1.6

ayon-documentation/website/docs/assets/json/Ayon_addons_version.json

Line 20 in 6116819

"Maya_Badge" : "[![Maya addon - 0.1.6](https://img.shields.io/badge/Maya_Addon-0.1.6-3190b2)](https://github.com/ynput/OpenPype/tree/develop/openpype/hosts/maya)",

@ynbot
Copy link

ynbot commented May 7, 2024

Task linked: OP-5920 Maya: abc options for Pointcache/Animation family

@tokejepsen
Copy link
Member Author

I have one question if you don't mind.
does the maya docs are aligned with the current maya addon version 0.1.17

Not sure about badges. Thinking it should be latest Maya add version, but will leave that to you.

@MustafaJafar
Copy link
Contributor

Not sure about badges. Thinking it should be latest Maya add version, but will leave that to you.

Fair! in some free time I'll compare the addon settings and the docs and will report if there are missing pieces.

@LiborBatek LiborBatek merged commit ad5f55f into main May 22, 2024
4 checks passed
@LiborBatek LiborBatek deleted the OP-5920_abc-options-for-Pointcache-Animation-family branch May 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar MustafaJafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tokejepsen @ynbot @MustafaJafar @LiborBatek