Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadline: Add docs for Process submitted job on farm plugin #135

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Feb 16, 2024

Changelog Description

Add docs for Process submitted job on farm plugin.

TODO:

  • Add definitions for the Process submitted job on farm plugin settings.

Additional Info

This PR was originally created for documenting families_transfer attribute OP-8268

@kalisp kalisp assigned antirotor and unassigned kalisp Feb 19, 2024
@tokejepsen tokejepsen changed the title Document families_transfer attribute on ProcessSubmittedJobOnFarm Document families_transfer attribute on ProcessSubmittedJobOnFarm - OP-8268 Feb 20, 2024
# Conflicts:
#	website/docs/addon_deadline_admin.md
@ynbot
Copy link

ynbot commented May 7, 2024

Task linked: OP-8268 AOV filter for Ftrack family

@MustafaJafar MustafaJafar changed the title Document families_transfer attribute on ProcessSubmittedJobOnFarm - OP-8268 Deadline: Add docs for Process submitted job on farm plugin Sep 9, 2024
@MustafaJafar
Copy link
Contributor

MustafaJafar commented Sep 9, 2024

This PR existed for some time.
It was originally created for documenting families_transfer attribute OP-8268
Personally, we can't document an attribute in a section without documenting the whole section therefore, I stretched the scope of this PR a little bit.

This PR still lacks some definitions for the Process submitted job on farm plugin settings

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update this PR. and I think it's ready to merge.
Feel free to review and ensure the documentation communicates well.

@MustafaJafar MustafaJafar self-requested a review September 12, 2024 09:57
@kalisp
Copy link
Member

kalisp commented Sep 12, 2024

I tried to clean up a bit chunk size issue in ynput/ayon-deadline#33 , so documentation might need to clean it up too.

@MustafaJafar MustafaJafar requested a review from BigRoy September 12, 2024 21:26
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update the PR in compliance with ynput/ayon-deadline#33
Also, added missing definitions for settings.

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just one small comment.

@MustafaJafar MustafaJafar merged commit e75d549 into main Sep 13, 2024
@MustafaJafar MustafaJafar deleted the OP-8268_AOV-filter-for-Ftrack-family branch September 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants