Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Enhancement: Houdini shelves manager tools_list are not added to the given shelf path #5738

Closed
2 tasks done
MustafaJafar opened this issue Oct 10, 2023 · 1 comment · Fixed by #5844
Closed
2 tasks done
Labels
host: Houdini type: enhancement Enhancements to existing functionality

Comments

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Oct 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

It's not a bug because it is the current default behavior of the shelves manager, it ignores tools_list if shelf path is given.

as @moonyuet mentioned here #5727 (review) and in the following discussion that it will be more intuitive to create a shelf with the given path and add these tools to it.

How would you imagine the implementation of the feature?

by specifying a file_path when crating a shelf.

def get_or_create_shelf_set(shelf_set_label):

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

[cuID:OP-7099]

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Nov 1, 2023

The shelves manager tool was designed based on giving users two options to add their shelves in Houdini.
The enhancement mentioned in this issue will increase the code complexity which make it harder to maintain,
In my opinion educating users about the proper usage of the tool is a better solution which should be done (at least) by giving hints in Houdini settings #5844

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Houdini type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant