Merge pull request #24 from ymmooot/no_tag

not make jsonld tags when jsonld method returns null
ymmooot · Jun 7, 2019 · c698195 · c698195
2 parents 53d692e + c4c8b0d
commit c698195
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/createMixin.ts b/src/createMixin.ts
@@ -33,6 +33,10 @@ export default (options: Options = {}): JsonldMixin => {
         return {};
       }
 
+      if (this.$options.jsonld.call(this) === null) {
+        return {};
+      }
+
       const stringifiedJson = JSON.stringify(this.$options.jsonld.call(this), null, mergedOptions.space);
       const innerHTML = mergedOptions.space === 0 ? stringifiedJson : `\n${stringifiedJson}\n`;
 

diff --git a/test/createMixin.spec.js b/test/createMixin.spec.js
@@ -89,6 +89,12 @@ describe('with jsonld', () => {
     });
   });
 
+  test('head method returns an empty object when jsonld returns null', () => {
+    const mock = mockInstanceFactory();
+    mock.$options.jsonld = () => null;
+    expect(mock.$options.head.call(mock)).toEqual({});
+  })
+
   describe('customizing indentation', () => {
     test('using tab', () => {
       const mock = mockInstanceFactory({ space: '\t' });