New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links on images not updating #138

Open

2 tasks done

jibin2706 opened this issue Jul 17, 2023 · 0 comments

Assignees

Labels

bug

jibin2706 commented Jul 17, 2023 •

edited

Loading

Checklist

Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/

Describe the bug
Marks on images are not getting updated from one document to other

To Reproduce
Steps to reproduce the behavior:

Go to the demo example of 'https://docs.yjs.dev/ecosystem/editor-bindings/prosemirror'
Click on Insert Image > Add an image
Click on the image & Click on add or remove link icon and add any link to that image
Inspect the image element, link is added on the first instance
Now inspect the image on other instance, changes are not updated

Expected behavior
The link should have been updated on both the editor instance.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment Information

Chrome

Additional context
Found this issue on Remirror which uses this library, so tried to reproduce the same.
remirror/remirror#2122

jibin2706 added the bug label

jibin2706 assigned dmonad

bosschaert mentioned this issue

prosemirrorToYXmlFragment losing <a> link around <img> tags #165

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment