Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect saving of checkpoints on train_xl.py #165

Open
brycegoh opened this issue Nov 21, 2024 · 3 comments
Open

Incorrect saving of checkpoints on train_xl.py #165

brycegoh opened this issue Nov 21, 2024 · 3 comments

Comments

@brycegoh
Copy link

Hi, I recently tested out the training script with --checkpointing_epoch=1 and gradient_accumulation_steps=1. I have a total dataset size of 10k with batch size of 5. This means that the script should be saving a checkpoint every 2000 steps. However, the checkpoint folder created is checkpoint-4000 and is being saved when the progress bar shows 4000 steps.

@rphly
Copy link

rphly commented Nov 21, 2024

fixed #164

@brycegoh
Copy link
Author

Thanks bro

@rphly
Copy link

rphly commented Nov 21, 2024

no problem @yisol @Sang-kyung @subin-kim-cv pls see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants