Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use predis to support replication and Sentinel #45

Open
djagya opened this issue Nov 19, 2015 · 12 comments
Open

Use predis to support replication and Sentinel #45

djagya opened this issue Nov 19, 2015 · 12 comments
Labels
type:feature New feature

Comments

@djagya
Copy link

djagya commented Nov 19, 2015

Do we want to add a new connection class, that will use predis (as e.g. laravel does) to support such features as replication and sentinel support? Or it could be set of abstract connection class with common things and two inherited to implement basic socket connection and predis connection.
I think it's a good step to HA.
Though sentinel support is still not in the stable predis branch, but it will soon, i think.

@samdark
Copy link
Member

samdark commented Nov 19, 2015

Using predis is a good idea.

@djagya
Copy link
Author

djagya commented Nov 20, 2015

I can create a PR. Also do we want to leave basic socket connection? Or since we're using predis for replication and sentinel - we can use it for basic connection too, therefore we'll have only one class.

@bazilio91
Copy link

Sure

On 20 Nov 2015, at 19:58, Danil Zakablukovskiy [email protected] wrote:

I can create a PR. Also do we want to leave basic socket connection?


Reply to this email directly or view it on GitHub.

@samdark
Copy link
Member

samdark commented Nov 20, 2015

Relying on predis only sounds OK to me.

@tom--
Copy link

tom-- commented Nov 20, 2015

High availability is a hard requirement for my project so I need something like this.

yii2-redis adoption of Predis' new Sentinel feature would be good for that project.

@tom--
Copy link

tom-- commented Nov 20, 2015

I noticed that predis is showing signs of having been abandoned. There was a little activity in the summer but nothing since July. Daniele's 12 month activity, compared to Twitter activity, shows perhaps a change of interests.

predis is used by Laravel and Doctrine and other projects. Does anyone have ideas who might be recruited into maintaining it?

@samdark samdark changed the title Replication and Sentinel support Use predis to support replication and Sentinel Nov 25, 2015
@cebe
Copy link
Member

cebe commented Jan 13, 2016

reference for sentinel implementation in yii 1.1.: yiisoft/yii#3106

@nrk
Copy link

nrk commented Jan 13, 2016

@tom-- I noticed this issue while browsing GitHub and just want to take the chance to clarify the current situation around Predis: it is definitely not an abandoned project! Sure there's been little to no activity from me on GitHub because I had an extremely busy 2015 (and btw I don't tweet that much compared to most of my tweeps ;-)) but thankfully the library is very stable with only a very few aknowledged but minor issues reported. Native support for redis-sentinel has been almost ready since... well, months! But I tend to hold back new important features until I'm not satisfied about how they are implemented and that's always been the case, even back when I had many green squares plotted in my GitHub activity graph ;-) Things should change in the next few weeks anyway.

@tom--
Copy link

tom-- commented Jan 13, 2016

@nrk I already noticed that activity resumed because I "subscribed" to all of predis in November. That was a relief.

In my own project, we are using @djagya's fork for now. I imagine his offer to send a PR with his fixes is still open.

Proper integration test of a realistic HA setup including clients for a predis+redis+sentinel is not at all simple and I understand your hesitance to release that, and especially because it is an HA feature. We've done basic testing on three VMs with our application using PHP sessions provided by Yii 2 via our fork of yii2-redis that uses predis and sentinel. But that's certainly not enough to really say that it works.

@cebe cebe added the type:feature New feature label Apr 5, 2017
@cebe cebe added this to the 2.0.x milestone Apr 5, 2017
@pavlelee
Copy link

pavlelee commented Jul 27, 2017

https://github.com/Liv1020/yii2-redis
This is ext for predis, predis can create phpredis connection class to use phpredis.
It's compatible with yii2-redis

@samdark samdark removed this from the 2.0.x milestone Apr 16, 2019
@frops
Copy link

frops commented Nov 6, 2019

Hello, have you any news, guys?

@samdark
Copy link
Member

samdark commented Nov 7, 2019

No. Noone is working on it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature
Projects
None yet
Development

No branches or pull requests

8 participants