You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 6, 2021. It is now read-only.
The /user/[address]/vaults/statistics endpoint returns results containing lower case vault addresses. This is in contrast to other endpoints that returned checksummed addresses.
This may require API users to have to process the results if their apps are expecting checksummed versions.
For consistency we should return checksummed addresses. This can be achieved simply with:
Edit: A thought just occurred.. as small a change as this is, it could be a breaking change if anyone has come to rely on the addresses being lowercase. Unlikely but worth mentioning.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The /user/[address]/vaults/statistics endpoint returns results containing lower case vault addresses. This is in contrast to other endpoints that returned checksummed addresses.
This may require API users to have to process the results if their apps are expecting checksummed versions.
For consistency we should return checksummed addresses. This can be achieved simply with:
const checkSummedAddress = Web3.utils.toChecksumAddress(upperOrLowerCaseAddress);
Edit: A thought just occurred.. as small a change as this is, it could be a breaking change if anyone has come to rely on the addresses being lowercase. Unlikely but worth mentioning.
The text was updated successfully, but these errors were encountered: