Skip to content

Commit

Permalink
Fix README and github action (#50)
Browse files Browse the repository at this point in the history
Now we ask users to install snappy through apt package
  • Loading branch information
tsayukov committed Mar 22, 2024
1 parent e2ff3a2 commit 69e8d7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 19 deletions.
10 changes: 1 addition & 9 deletions .github/actions/prepare_vm/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ runs:
sudo apt-get -y update
sudo apt-get -y install git cmake ninja-build libidn11-dev ragel yasm protobuf-compiler \
protobuf-compiler-grpc libprotobuf-dev libgrpc++-dev libgrpc-dev libgrpc++1 libgrpc10 \
rapidjson-dev zlib1g-dev libxxhash-dev libzstd-dev
rapidjson-dev zlib1g-dev libxxhash-dev libzstd-dev libsnappy-dev
wget https://apt.llvm.org/llvm.sh
chmod u+x llvm.sh
sudo ./llvm.sh 16
Expand All @@ -23,14 +23,6 @@ runs:
sudo make
sudo make install
cd ..
wget https://github.com/google/snappy/archive/refs/tags/1.1.10.tar.gz
tar -xzvf 1.1.10.tar.gz
cd snappy-1.1.10
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local -DBUILD_SHARED_LIBS=ON \
-DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF ..
sudo cmake --build . --target install
cd ../..
(V=4.8.1; curl -L https://github.com/ccache/ccache/releases/download/v${V}/ccache-${V}-linux-x86_64.tar.xz | \
sudo tar -xJ -C /usr/local/bin/ --strip-components=1 --no-same-owner ccache-${V}-linux-x86_64/ccache)
sudo rm -rf llvm.sh libiconv-1.15
13 changes: 3 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ If you ok with this warning, then...
- xxhash
- zlib
- zstd
- snappy 1.1.10+
- snappy 1.1.8+

## Runtime requirements

Expand All @@ -39,7 +39,7 @@ If you ok with this warning, then...
sudo apt-get -y update
sudo apt-get -y install git cmake ninja-build libidn11-dev ragel yasm protobuf-compiler \
protobuf-compiler-grpc libprotobuf-dev libgrpc++-dev libgrpc-dev libgrpc++1 libgrpc10 \
rapidjson-dev zlib1g-dev libxxhash-dev libzstd-dev
rapidjson-dev zlib1g-dev libxxhash-dev libzstd-dev libsnappy-dev

wget https://apt.llvm.org/llvm.sh
chmod u+x llvm.sh
Expand All @@ -50,14 +50,7 @@ tar -xvzf libiconv-1.15.tar.gz
cd libiconv-1.15
./configure --prefix=/usr/local
sudo make
sudo make install && cd ..

wget https://github.com/google/snappy/archive/refs/tags/1.1.10.tar.gz
tar -xzvf 1.1.10.tar.gz
cd snappy-1.1.10 && mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local -DBUILD_SHARED_LIBS=ON \
-DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF ..
sudo cmake --build . --target install && cd ../..
sudo make install
```

## Create the work directory
Expand Down

0 comments on commit 69e8d7c

Please sign in to comment.