ci is failing, will debug tomorrow

Could you also test if there are improvements with the test-80-compression-node-opcua test? It actually takes 5 min on ubuntu to complete.

Seems now it went down to 2min: https://github.com/yao-pkg/pkg/actions/runs/11675697212/job/32510712730?pr=121#step:7:20 :) I think there is still range of improvement here. Could you try enabling that test also for windows and mac?

Just remove this lines:

I also created #122, I would like to compare performances of tests in this two PR

from my local tests in the zip repro of #119 this should be faster than #122, since the unnecesary glob calls were still present back then

In fact seems this is faster 👍🏼

okay i see why at least some tests fail, it's due to this project using directory expansion, which means that globbing dir is the same as globbing dir/**. dir itself is technically not dynamic so it gets skipped which shouldn't happen

@SuperchupuDev Yep understood, could you fix that?

trying

okay, fixing it would just make all patterns dynamic, making performance not change whatsoever. we need a better solution. there needs to be a refactor in the walker logic so that all patterns are pushed into an array and then when all of them are collected call globSync once

@SuperchupuDev Makes sense, agreee

@SuperchupuDev News on this?

been busy with university, i have to debug and figure out why vite's tests fail with tinyglobby's upcoming version (which should fix the perf issue), could try today

@robertsLando changed this pr to the upcoming tinyglobby version instead, can you compare performance again?

Here the time was 2 min: https://github.com/yao-pkg/pkg/actions/runs/11675697212/job/32510712730?pr=121#step:7:20

Now it's 4 minutes: https://github.com/yao-pkg/pkg/actions/runs/12070674103/job/33660704757?pr=121#step:7:20

On master it's 4 minutes as well: https://github.com/yao-pkg/pkg/actions/runs/11971054226/job/33375067804#step:7:20

okay, thanks. fyi it's 4 minutes on fast-glob as well: https://github.com/yao-pkg/pkg/actions/runs/11703987586/job/32595478258?pr=122#step:7:20

although this pr should solve the perf issue reported in #119, for the record, if you want to avoid unnecesary globbing one solution can be setting expandDirectories to false in tinyglobby's options, then doing what this pr did before i force pushed. it'd be a breaking change though as users would have to replace some of their patterns i.e. src with src/**

Ok thanks for that! I would not go for that option as I think there will be too much edge cases to handle and I'm quite sure it could cause some unexpected issues I don't want to deal with right now. We can merge this if it's ready 👍🏼

I correct myself: we can merge this once you have a release for tinyglobby :)