Make pkg dependent on node-sea

[Sadzurami]

Just an idea, that can change and make easier maintaining of this project.

What about significantly change pkg methods for creating executable?
Since node officially supports sea, pkg can depends of it.

No need to patch node every time. It can reduce required boilerplate for future releases.

• Why not to use node-sea directly?
• Because it requires more additional and not convenient steps to make one single executable, while pkg can make it with one single command.

Key suggestion is - make pkg dependent on node-sea and preserve existing api / cli interfaces.

[robertsLando]

@Sadzurami This is the idea for the future, BTW implementing this is still very complicated as sea is still missing support for VFS (virtual file system). Actually it supports adding assets to the file but not multiple js files. In order to fix this there should be a pre-build step using esbuild or bpkg that will take care of bundling everything to a single file but this may require some tweaks in complex applications

[robertsLando]

Dealing with some custom implementation of VFS could be a real pain

[segevfiner]

You already have one. In the bootstrap.js of pkg. Just a matter of making it get the binary blob it uses from the sea asset instead of the appended blob to the executable I think.

[robertsLando]

I would create a dedicated one for sea instead of editing that one as that's huge and actually has lot of useless stuff.

Do you want to submit a PR?

[segevfiner]

Makes sense. But it does have a lot of code for the VFS stuff... So might need to refactor and maybe generate those files using a bundler. (It is also rather messy code IMHO).

I can't guarantee I'll have any time to take a stab at this anytime soon though... I'm overloaded in both personal life and work 😔

[robertsLando]

No worries, btw I agree with this, also the bundler could allow us to write them using ts for better type checking