-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider "Support stack traces with correct line numbers even without embedding sources" #10
Comments
This would require a duplicated patch for all nodejs patches so, one with line numvers support and one without.... or just add the line numbers patch and apply that only when nodejs is built from source... This requires adding a new option to pkg that is then propagated to pkg fetch and will eventually do the double patch of the nodejs version. This also requires all this patches to be someway maintained as long as the main patches change and I find this very difficult to happen... we struggle to keep the main patches maintained |
Best to stay with one patch for each version and add an option. Like the existing sourceless option they already add. This project could definitely use some scripts to help maintaining the patches so it isn't such a manual and laborous process. |
There is no way to create such scripts |
Not to fully automate the entire thing, as it obviously requires manual intervention. But to streamline it a bit. e.g.
Just to make it slightly less of a manual process. |
PR? |
See https://github.com/vercel/pkg/discussions/1682. Optionally, of course.
The text was updated successfully, but these errors were encountered: