Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider "Support stack traces with correct line numbers even without embedding sources" #10

Open
segevfiner opened this issue Oct 25, 2023 · 5 comments

Comments

@segevfiner
Copy link

See https://github.com/vercel/pkg/discussions/1682. Optionally, of course.

@robertsLando
Copy link
Member

This would require a duplicated patch for all nodejs patches so, one with line numvers support and one without.... or just add the line numbers patch and apply that only when nodejs is built from source... This requires adding a new option to pkg that is then propagated to pkg fetch and will eventually do the double patch of the nodejs version. This also requires all this patches to be someway maintained as long as the main patches change and I find this very difficult to happen... we struggle to keep the main patches maintained

@segevfiner
Copy link
Author

Best to stay with one patch for each version and add an option. Like the existing sourceless option they already add. This project could definitely use some scripts to help maintaining the patches so it isn't such a manual and laborous process.

@robertsLando
Copy link
Member

This project could definitely use some scripts to help maintaining the patches so it isn't such a manual and laborous process.

There is no way to create such scripts

@segevfiner
Copy link
Author

This project could definitely use some scripts to help maintaining the patches so it isn't such a manual and laborous process.

There is no way to create such scripts

Not to fully automate the entire thing, as it obviously requires manual intervention. But to streamline it a bit. e.g.

  1. Download the relevant node.js version, extract it twice to two directories, and patch one of them.
  2. A second script to generate the patch from this two directories.

Just to make it slightly less of a manual process.

@robertsLando
Copy link
Member

PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants