Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 Update :D #67

Open
johisco opened this issue Sep 16, 2016 · 11 comments
Open

Swift 3 Update :D #67

johisco opened this issue Sep 16, 2016 · 11 comments

Comments

@johisco
Copy link

johisco commented Sep 16, 2016

No description provided.

@antjebara
Copy link

Please

@bill350
Copy link

bill350 commented Oct 10, 2016

Hey guys, I temporarly use the @zahlz fork repository which is Swift 3 compatible.

https://github.com/zahlz/SwiftPasscodeLock

I hope they will create a PR.

@jabwd
Copy link

jabwd commented Jan 12, 2017

Just download this repository and use the build in converter in Xcode. This project does not cause any issues whatsoever. Just don't include it using one of the package managers, as you never should anyway.

@waltermvp
Copy link

@jabwd is there a reason we should not be using package managers? (i assume your talking about cocoapods, carthage, SPM)

@jabwd
Copy link

jabwd commented Feb 9, 2017

@waltermvp In my opinion, they cause more trouble than they're worth. Case and point: People want this repo updated but can just do it themselves without any trouble. You need to fork anyway if you even were planning on slight updates. git submodules > SPM on linux > manual inclusion.

Its a dependency for managing dependencies..

@ziogaschr
Copy link
Contributor

You have a look at this repo for a while, which supports Swift3 https://github.com/velikanov/SwiftPasscodeLock

p.s.: I hope that these two repos will be merged at some point

@mssun
Copy link

mssun commented Apr 7, 2017

@ziogaschr thanks. I'm considering to switch to your fork. I see yours has new patches and still under actively developed.

@ziogaschr
Copy link
Contributor

Thanks @mssun. It's @velikanov's repo, but yes we are trying to keep it up to date. It will be nice if we can keep only one repo (the main one - this) so as we all contribute at one place.

@bill350
Copy link

bill350 commented Apr 12, 2017

So @ziogaschr, the https://github.com/velikanov/SwiftPasscodeLock is the "official" ?

@waltermvp
Copy link

Yep

@ziogaschr
Copy link
Contributor

xexe, no this one from @yankodimitrov is the official. Although in my view the @velikanov's one is more updated.

@yankodimitrov made us contributors (thanks for that honor), although we never merged the two repos so as we can continue with this one. I am using this lib in a production App and the missing bit in this repo doesn't allow me to continue contributing here.

So usually, I make a lot of changes at my repo https://github.com/ziogaschr/SwiftPasscodeLock, test them live for a while and the push them to @velikanov's repo.`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants