Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with original paper. #165

Open
GLivshits opened this issue Nov 7, 2022 · 1 comment
Open

Inconsistencies with original paper. #165

GLivshits opened this issue Nov 7, 2022 · 1 comment

Comments

@GLivshits
Copy link

GLivshits commented Nov 7, 2022

Hello. There are some inconsistencies with the paper and the code:

  1. I dont see any feature matching loss in your code.
  2. PPL and R1 losses are not mentioned in paper, but used in your training.
  3. Batch size of 1 mentioned in paper, but standard batch size choice in your code is 4.
  4. It is not clear for how long to train the model.
  5. Did you account spatial size of every discriminator feature level in feature matching loss (such as taking mean instead of sum)? From the paper it is not clear, as there was only sum of norms without any normalization factors regarded to spatial size.
    Can you please clarify those moments? It seems like the code used in paper and the code that is allowed to show publically are quite different.
@fmu2
Copy link

fmu2 commented Nov 29, 2022

A somewhat related question...

Can you please point us to the pre-trained weights that reproduce the exact model described in the paper? I am asking because we want to fairly compare with your method. It is unclear whether the provided weights are trained using private data (in addition to the publicly available FFHQ dataset) or techniques introduced after acceptance of the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants