Skip to content
This repository has been archived by the owner on Oct 18, 2019. It is now read-only.

Python3 Support #76

Open
robputt opened this issue Sep 11, 2018 · 8 comments
Open

Python3 Support #76

robputt opened this issue Sep 11, 2018 · 8 comments

Comments

@robputt
Copy link

robputt commented Sep 11, 2018

Hi,

Most modern Linux distributions are packaging python-caffe only for Python3 and hence getting this up and running has been a pain for me, it would be super awesome if the sample script could be made Python3 friendly. I will probably tidy up what I have locally here to fix this and raise a PR.

Best Regards,

Rob

@rahiel
Copy link
Collaborator

rahiel commented Nov 2, 2018

I have a fork of open_nsfw with Python3 support here: https://github.com/rahiel/open_nsfw--

@robputt
Copy link
Author

robputt commented Nov 3, 2018

Awesome I will check it out, but is there any chance to port this back into the upstream repo?

@rahiel
Copy link
Collaborator

rahiel commented Nov 4, 2018

As far as I can see, this repo is not maintained anymore. There are many pull requests left open. That's why I decided to fork it. This fork also has an additional goal of making it very easy to deploy the model in production.

I can upstream Python3 support if this repo becomes active again.

@BenLloydPearson
Copy link

@rahiel, We don't have anyone to maintain this repo anymore, but we're more than happy to hand it off to community members to take on maintainership. Is this something you'd be interested in? Or would you simply be interested in upstreaming python 3 support? I can grant you write access either way.

@rahiel
Copy link
Collaborator

rahiel commented Nov 7, 2018

Hey @BenLloydPearson, I am interested in maintaining this.

Do you think the HTTP REST interface I made at open_nsfw-- would be a fit for the main open_nsfw project? The benefit of a HTTP interface is that people can use it with any programming language they like.

@robputt
Copy link
Author

robputt commented Nov 7, 2018

I think the REST interface is interesting but I'd much prefer it if we could pass a multipart encoded file object, or a URL, something we can easily expand on. I agree we need a new maintainer for this, my main interest in OpenNSFW is for inclusion as a plugin in OpenStack Nemesis, it aims to make a file scanning API which provides intelligence about files. - https://github.com/openstack/nemesis

@rahiel
Copy link
Collaborator

rahiel commented Nov 7, 2018

I think the REST interface is interesting but I'd much prefer it if we could pass a multipart encoded file object, or a URL, something we can easily expand on. I agree we need a new maintainer for this, my main interest in OpenNSFW is for inclusion as a plugin in OpenStack Nemesis, it aims to make a file scanning API which provides intelligence about files. - https://github.com/openstack/nemesis

Currently you can already pass URLs to the API , I've made an issue for multipart encoded files (1#).

@BenLloydPearson
Copy link

@rahiel I invited you to have write access to this repo so you can work on merging improvements. There is currently branch protection on master to require one review before merging PR's. This will allow you to merge other's improvements, and feel free to ping me directly if you need help with reviews for your PR's. If anyone else in this thread is interested in helping with this, please reach out to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants