Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to disable onScroll replaceState ? #448

Closed
Diokuz opened this issue Jun 11, 2016 · 1 comment
Closed

How to disable onScroll replaceState ? #448

Diokuz opened this issue Jun 11, 2016 · 1 comment

Comments

@Diokuz
Copy link
Contributor

Diokuz commented Jun 11, 2016

IOS safari has a bug https://forums.developer.apple.com/thread/36650
And we have a problem, because each scroll leads to history.replaceState.

How to disable it? We dont need scroll handling at all.

Maybe just make some if (options.enableScroll) here:

https://github.com/yahoo/fluxible/blob/master/packages/fluxible-router/lib/handleHistory.js

?
This was referenced Jun 11, 2016
Closed
Merged
@mridgway mridgway mentioned this issue Jun 22, 2016
Open
@mridgway
Copy link
Collaborator

A refactor for scroll state should be discussed in #336. Since this specific issue is resolved in #450 for now, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mridgway @Diokuz