From 78d8eb9a1604831ef85a7a577be111fb56f39561 Mon Sep 17 00:00:00 2001
From: ldevillez <louis.devillez@gmail.com>
Date: Tue, 28 Nov 2023 00:30:17 +0100
Subject: [PATCH] pylint

---
 svg2tikz/tikz_export.py | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/svg2tikz/tikz_export.py b/svg2tikz/tikz_export.py
index ce9e424..4330a6a 100644
--- a/svg2tikz/tikz_export.py
+++ b/svg2tikz/tikz_export.py
@@ -390,6 +390,14 @@ def marking_interpret(marker):
     return raw_marker
 
 
+def options_to_str(options: list) -> str:
+    """
+    Convert a list of options to a str with comma separated value.
+    If the list is empty, return an empty str
+    """
+    return f"[{','.join(options)}]" if len(options) > 0 else ""
+
+
 def return_arg_parser_doc():
     """
     Methode to return the arg parser of TikzPathExporter to help generate the doc
@@ -858,7 +866,7 @@ def style_to_tz(self, node=None):
 
         return options
 
-    def trans_to_tz(self, node=None, isNode=False):
+    def trans_to_tz(self, node=None, is_node=False):
         """
         Convert inkex transform to tikz code
         """
@@ -877,7 +885,7 @@ def trans_to_tz(self, node=None, isNode=False):
                 tr = self.convert_unit_coord(Vector2d(trans.e, trans.f), False)
 
                 # Global scale do not impact transform
-                if not self.options.noreversey or isNode:
+                if not self.options.noreversey or is_node:
                     tr.y *= -1
 
                 tr.x *= self.options.scale
@@ -917,15 +925,14 @@ def trans_to_tz(self, node=None, isNode=False):
                 d = self.round_value(trans.d)
 
                 # globalscale do not impact transform
-                if not self.options.noreversey or isNode:
+                if not self.options.noreversey or is_node:
                     tr.y *= -1
                     b *= -1
                     c *= -1
 
-                if not self.options.noreversey and not isNode:
+                if not self.options.noreversey and not is_node:
                     tr.x += -c * self.update_height(0)
                     tr.y += (1 - d) * self.update_height(0)
-                    pass
 
                 tr.x *= self.options.scale
                 tr.y *= self.options.scale
@@ -1257,6 +1264,7 @@ def get_text(self, node):
         """Return content of a text node as string"""
         return etree.tostring(node, method="text").decode("utf-8")
 
+    # pylint: disable=too-many-branches
     def _output_group(self, group):
         """Process a group of SVG nodes and return corresponding TikZ code
 
@@ -1278,8 +1286,9 @@ def _output_group(self, group):
                 string += self._handle_group(node)
                 continue
             try:
-                isNode = node.TAG in ["text", "flowRoot", "image"]
-                goptions = self.style_to_tz(node) + self.trans_to_tz(node, isNode)
+                goptions = self.style_to_tz(node) + self.trans_to_tz(
+                    node, node.TAG in ["text", "flowRoot", "image"]
+                )
             except AttributeError as msg:
                 attr = msg.args[0].split("attribute")[1].split(".")[0]
                 logging.warning("%s attribute cannot be represented", attr)
@@ -1290,7 +1299,7 @@ def _output_group(self, group):
                 string += self.text_indent + f"%{node.get_id()}\n"
 
             if node.TAG == "path":
-                optionscode = f"[{','.join(goptions)}]" if len(goptions) > 0 else ""
+                optionscode = options_to_str(goptions)
 
                 pathcode = f"\\path{optionscode} {self.convert_path_to_tikz(node.path)}"
 
@@ -1298,8 +1307,7 @@ def _output_group(self, group):
                 # Add indent
                 pathcode, options = self._handle_shape(node)
 
-                goptions += options
-                optionscode = f"[{','.join(goptions)}]" if len(goptions) > 0 else ""
+                optionscode = options_to_str(goptions + options)
 
                 pathcode = f"\\path{optionscode} {pathcode}"
 
@@ -1314,7 +1322,7 @@ def _output_group(self, group):
                 if not contains_anchor:
                     goptions += ["anchor=south west"]
 
-                optionscode = f"[{','.join(goptions)}]" if len(goptions) > 0 else ""
+                optionscode = options_to_str(goptions)
                 # Convert a rotate around to a rotate option
                 if "rotate around={" in optionscode:
                     splited_options = optionscode.split("rotate around={")