-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream does not check database tables exist #1284
Comments
Working around this I got: wp_stream_get_instance()->install->check(); Running that code once created the tables |
I made a quick PR that adds them when the DB resets, however, the
|
Thanks for reporting the issue @tomjn! This appears to be related to this very recent change #1201 which was attempting to fix this issue #1169 What would be the most performant way of ensuring the tables exist if we’re doing that on pretty much every request? Could we use an option to store the schema revision once the tables are created and then assume that the tables are present while the options is there? |
@kasparsd see my last PR, it only checks on WP Admin/CLI requests, avoiding the issue you linked to |
the reset PR also provides a manual way to fix this |
@kasparsd yes, just need a release with it in and I'll have some very happy people :) Closing |
Thanks for the confirmation and your contribution! I'll create a release either today or early next week. |
@tomjn 3.8.1 is out now:
|
Bug Report
Stream only creates database tables on plugin activation, then never checks they exist.
Expected Behavior
Use Stream in an environment here plugin activation occurs.
Stream sees that the tables don't exist and creates them.
Actual Behavior
Stream does not create the tables because you did not load the plugin by activating it.
Additionally, the reset database tables link in settings does not create the tables if they do not exist
Steps to Reproduce the Problem
System Information
If making it auto-check isn't possible, providing a way to create the tables would also be great. Right now this is extremely frustrating and regularly causes problems with local environments on multiple projects.
The text was updated successfully, but these errors were encountered: