Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to Change Settings for this library #34

Open
Legohead259 opened this issue Dec 25, 2022 · 0 comments
Open

Difficult to Change Settings for this library #34

Legohead259 opened this issue Dec 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Legohead259
Copy link

Hi there! I have been trying to set up this library for a project. I have used the example code found in the ESP32 examples, but noticed some things that could be improved.

  1. It is difficult to determine which storage system is currently being used. When first testing the "SD card" example, I could open the server and connect to it with a client (WinSCP). But, nothing was showing up. It was only after digging a bit and changing the DEFAULT_STORAGE definition to STORAGE_SD that it worked. None of the debug flags actually told me what was being used
  2. Speaking of debug flags it is difficult to figure out what flags need to be defined in order for it to work as intended. I think a section at the top of FtpServer.h that can be commented/uncommented as needed would be beneficial (if this is already included, perhaps better highlighting would be prudent as I couldn't find anything)
  3. When experimenting if I could change the storage type for the FTP server without changing anything in the library files, I noticed that if the definitions are redefined in the main example a compiler warning is issued and the change is not implemented. I tried both before and after the #include <FtpServer.h> call, but neither worked.If there could be someway to modify the storage type without messing with the library files (something important in an environment where the library may be updated or deleted/re-downloaded) that would be excellent!

Thanks,

@xreef xreef added the enhancement New feature or request label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants