Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seed in response object #46

Merged
merged 3 commits into from
Aug 30, 2023
Merged

add seed in response object #46

merged 3 commits into from
Aug 30, 2023

Conversation

jonathanlei
Copy link
Contributor

@jonathanlei jonathanlei commented Aug 29, 2023

add wallet seed back in successful response objects (if the user didn't provide a funding destination address)

src/types.ts Outdated Show resolved Hide resolved

const response: FundedResponse = {
account: account,
amount: amount,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed from Number(amount)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the type to number

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanlei jonathanlei merged commit fac2fe7 into master Aug 30, 2023
@ggprod ggprod deleted the add-seed branch August 30, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants