Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivateWindow(Favourites) works only from main menu #8

Open
boot2k3 opened this issue Feb 18, 2018 · 4 comments
Open

ActivateWindow(Favourites) works only from main menu #8

boot2k3 opened this issue Feb 18, 2018 · 4 comments
Assignees
@xhaggi
Labels
Bug Valid
Milestone
Leia 18.x

Comments

@boot2k3
Copy link

boot2k3 commented Feb 18, 2018

Is it possible to fix possibility to show Favourites from PVR, Video, Music pages and etc?
@xhaggi
Copy link
Member

xhaggi commented Mar 4, 2018

I've to look into it.

@xhaggi xhaggi added the Bug label Mar 4, 2018
@xhaggi xhaggi self-assigned this Mar 4, 2018
@xhaggi xhaggi added this to the Leia 18.x milestone Mar 4, 2018
@xhaggi
Copy link
Member

xhaggi commented Mar 4, 2018

The favourites dialog now works correctly on top of the PVR windows (fixed by 90cc85b). No issues on my side for the other windows like Video, Music etc. There the favourites dialog works fine.

@boot2k3
Copy link
Author

boot2k3 commented Mar 5, 2018 •
edited
Loading

It's now visible in PVR, Music and Video windows, thank you.
But I forgot to say what it's not visible while Video, PVR or Music playing.

I don't know if is it right or not, but after remove + !Window.IsActive(fullscreenvideo) from DialogFavourites.xml it shows Favourites while playing

@xhaggi
Copy link
Member

xhaggi commented Mar 5, 2018

Will take another look at it.

@xhaggi xhaggi added the Valid label Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xhaggi xhaggi

Labels
Bug Valid
Projects
None yet
Milestone
Leia 18.x
Development

No branches or pull requests
2 participants
@xhaggi @boot2k3