Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of circular includes #1

Open
3 tasks
xoorath opened this issue Feb 9, 2022 · 0 comments
Open
3 tasks

Improve detection of circular includes #1

xoorath opened this issue Feb 9, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@xoorath
Copy link
Owner

xoorath commented Feb 9, 2022

Currently Source/Renderer.cpp has a hard coded include depth limit of 30 (see k_maxIncludeDepth). This is to detect/handle circular includes with a limit that's high and unlikely limit to occur in real uses of esd.

This can be improved by detecting circular includes prior to rendering anything by building some kind of include graph with that detection.

Goals for this improvement:

  • No coded-in limit to the depth of includes.
  • Detection occurs before rendering / before the output file or any temporary files are created or modified.
  • Detection indicates to the user how to fix their problem / what files are a part of the circular dependency.
@xoorath xoorath self-assigned this Feb 9, 2022
@xoorath xoorath moved this to In Progress in Electrostatic Discharge Feb 9, 2022
@xoorath xoorath moved this from In Progress to Todo in Electrostatic Discharge Feb 9, 2022
@xoorath xoorath added this to the v1.0 milestone Feb 9, 2022
@xoorath xoorath added enhancement New feature or request and removed Improvement labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant