Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing of snapshot datetime format #6

Open
danyx23 opened this issue May 24, 2020 · 0 comments
Open

Allow customizing of snapshot datetime format #6

danyx23 opened this issue May 24, 2020 · 0 comments

Comments

@danyx23
Copy link

danyx23 commented May 24, 2020

First of all, thanks for this tool, this is a really convenient way of getting sane backups working quickly :).

I have one suggestion and would send a PR if you agree with the addition: I'd like the datetime format that is used as the directory name of the snapshot to be configurable from the cli. The reason for this is that I am using this on a pretty basic NAS system that exposes the backup folders read only as samba shares, but windows does not allow the colon character in file or directory names that is used as an hour/minutes separator by this script. If this where customizable to e.g. dash then the backups could be directly accessed via SMB. Because this is a NAS system with some weird busybox distribution, this change seems like the most straightforward and maybe others would like to be able to customize the format as well.

If you agree I would add a config option to override the strftime call in

time.strftime('%Y-%m-%d %H:%M:%S'))

Would you be willing to consider such a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant