Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve senderWrapper Update func #226

Open
kristinapathak opened this issue Jul 16, 2020 · 1 comment
Open

Improve senderWrapper Update func #226

kristinapathak opened this issue Jul 16, 2020 · 1 comment
Assignees
@kcajmagic
Labels
argus-webhooks Securing webhooks for the switch to argus enhancement needs discussion

Comments

@kristinapathak
Copy link
Contributor

caduceus/senderWrapper.go

Line 132 in 453f141

func (sw *CaduceusSenderWrapper) Update(list []webhook.W) {

With argus, we don't need the undertaker anymore and should delete webhooks in our update function.
@kristinapathak kristinapathak added enhancement argus-webhooks Securing webhooks for the switch to argus labels Jul 16, 2020
@kristinapathak kristinapathak changed the title We should update better Improve senderWrapper Update func Jul 16, 2020
@kristinapathak
Copy link
Contributor Author

When discussing a production issue in Caduceus, I remember @schmidtw saying that he wants to maintain Caduceus' functionality of holding onto an expired webhook for a bit. So I'm not sure if we should do this or how we could do this to maintain that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcajmagic kcajmagic

Labels
argus-webhooks Securing webhooks for the switch to argus enhancement needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kcajmagic @kristinapathak