Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry.py: migrate deprecated pkg_resources #145

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

registry.py: migrate deprecated pkg_resources #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions isbnlib/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

import logging

# 'pkg_resources' is deprecated! SEE https://setuptools.pypa.io/en/latest/pkg_resources.html
from pkg_resources import iter_entry_points
from importlib.metadata import entry_points

from . import NotValidDefaultFormatterError, NotValidDefaultServiceError
from . import _goob as goob
Expand Down Expand Up @@ -86,7 +85,7 @@ def load_plugins(): # pragma: no cover
# get metadata plugins from entry_points
if options.get('LOAD_METADATA_PLUGINS', True):
try:
for entry in iter_entry_points(group='isbnlib.metadata'):
for entry in entry_points(group='isbnlib.metadata'):
add_service(entry.name, entry.load())
except Exception:
LOGGER.critical('Some metadata plugins were not loaded!')
Expand Down