Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define clippy allowed lints in code #1744

Closed
shssoichiro opened this issue Oct 8, 2019 · 0 comments · Fixed by #1745
Closed

Define clippy allowed lints in code #1744

shssoichiro opened this issue Oct 8, 2019 · 0 comments · Fixed by #1745
Labels
code cleanup easy Can be done in less than 4 hours of work by an experienced codec engineer.

Comments

@shssoichiro
Copy link
Collaborator

We can define e.g. #[allow(clippy::annoying_lint)] at the top of lib.rs and main.rs instead of specifying them inline in .travis.yml. This would make it easier for newcomers to the project to not need to know we have a special clippy command. This has been allowed for a few rust versions now (it used to break compiling if you weren't running clippy--now it's ignored if you don't have clippy and works fine). This would also remove the need for #1406.

@shssoichiro shssoichiro added code cleanup easy Can be done in less than 4 hours of work by an experienced codec engineer. labels Oct 8, 2019
shssoichiro added a commit to shssoichiro/rav1e that referenced this issue Oct 9, 2019
shssoichiro added a commit to shssoichiro/rav1e that referenced this issue Oct 9, 2019
shssoichiro added a commit that referenced this issue Oct 9, 2019
lu-zero pushed a commit to rust-av/rav1e that referenced this issue Nov 27, 2019
barrbrain pushed a commit to barrbrain/rav1e that referenced this issue Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup easy Can be done in less than 4 hours of work by an experienced codec engineer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant