Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically enable --fpr with high bit depth input #195

Open
negge opened this issue Jul 25, 2016 · 1 comment
Open

Automatically enable --fpr with high bit depth input #195

negge opened this issue Jul 25, 2016 · 1 comment

Comments

@negge
Copy link
Contributor

negge commented Jul 25, 2016

Right now encoding a high bit depth y4m file fails silently with the nebulous error:

$ ./encoder_example tiny420p10.y4m -o tiny420p10.ogv
File 'tiny420p10.y4m' is 2x2 25.000 fps 420p10 video.
Failed to create encoder.

This is fixed by adding the --fpr flag. If depth > 8 is detected, we should automatically turn this feature on.

@danesh-d
Copy link
Contributor

Seems to be relatively straightforward to do. Would it be OK if I work on it? Also, is there any y4m example file which I can use to reproduce the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants