Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in error handling if no IP address is found #56

Open
stormi opened this issue Jun 11, 2019 · 3 comments
Open

Error in error handling if no IP address is found #56

stormi opened this issue Jun 11, 2019 · 3 comments

Comments

@stormi
Copy link

stormi commented Jun 11, 2019

This line of code fails when executed, with message AttributeError: 'module' object has no attribute 'ERROR_CAUSE_NETWORK' https://github.com/xenserver/xscontainer/blob/master/src/xscontainer-prepare-vm#L80

See this bug reported by a user of XCP-ng, with full backtrace: xcp-ng/xcp#198

I don't know the code of xscontainer enough to provide a patch, but the fix should be easy.

@stormi
Copy link
Author

stormi commented Apr 20, 2020

Ping?

@LunarstarPony
Copy link

Meh Same here

@dalrrard
Copy link
Contributor

Looks like this was introduced by commit 2814280 when they were separating out some functionality. I don't have time to test right now, but line 80 should probably be modified to be print(remote_helper.ssh.ERROR_CAUSE_NETWORK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants