xen-dom-mgmt: improvements for dom0 initcall #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorc
approved these changes
Apr 12, 2024
Redundant k_free() call was spuriously added to dom0 initcall, which may lead to double-free problems with CONFIG_XSTAT. Signed-off-by: Dmytro Firsov <[email protected]> Acked-by: Volodymyr Babchuk <[email protected]>
Some return codes in dom0 initcall were ignored. Also return value from initcall was improper (positive integer from last call, when Zephyr initcall expects it to be 0 in success case). Add error handling in initcall and add proper return value xs_init_root to return proper result to initcall instead of just 0. Signed-off-by: Dmytro Firsov <[email protected]> Acked-by: Volodymyr Babchuk <[email protected]>
Result from xstat sysctl was tested on 0, which stands for 0 active domains. This condition is theoretically impossible in Dom0 and definitely not a valid state, so change it to ASSERT instead of if condition. Signed-off-by: Dmytro Firsov <[email protected]> Acked-by: Volodymyr Babchuk <[email protected]>
firscity
force-pushed
the
dom0_initcall_fixes
branch
from
ed014cd to
6520983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes suggested in #63