fetchers: disable prompt usage by git #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with https access to the private repo. |
rshym
force-pushed
the
mr_prompt
branch
2 times, most recently
from
4ca8759 to
1ffa33f
Compare
|
Rebased on the latest changes. |
|
Thanks |
This commit addresses issue with git interacting with the user through the console. For example, HTTPS access to the private repo. We use git inside the hidden console, so user sees only hanging fetch. So, we instruct the git to not interact with the user by the command `GIT_TERMINAL_PROMPT=0`. As result, git fails cloning and inform user that asking name/password is not possible. This should push the user to use script-friendly authorization, like ssh. Suggested-by: Artem Mygaiev <[email protected]> Signed-off-by: Ruslan Shymkevych <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue with git interacting with the user through the console. For example, HTTPS access to the private repo.
We use git inside the console, that is hidden from the user, so user see only hanging fetch.
So, we instruct the git to not interact with the user by the command
GIT_TERMINAL_PROMPT=0. As result, git fails cloning and inform user that asking name/password is not possible.This should push the user to use script-friendly authorization, like ssh.
Suggested-by: Artem Mygaiev [email protected]