custom_script: Make the 'args' parameter optional #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the spelling in the commit message and add test for all the cases. |
Moulin didn't work if 'args' parameter absent. Make that parameter optional Signed-off-by: Dmytro Semenets <[email protected]>
what you mean 'add test'? I have tested for all cases |
|
There is a test framework enabled in Moulin to run automated unit tests: https://github.com/xen-troops/moulin/tree/main/tests You need to implement unit tests for |
|
Added tests |
lorc
reviewed
Mar 5, 2024
Add tests for custom_script builder Signed-off-by: Dmytro Semenets <[email protected]>
|
Thank you. I rebased and merged your changes manually, so I am closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moulin didn't work if 'args' parameter absent. Make that paremeter optional