Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to compile on Ubuntu LTS 14.04 #1

Open
avagin opened this issue Apr 23, 2014 · 3 comments
Open

Unable to compile on Ubuntu LTS 14.04 #1

avagin opened this issue Apr 23, 2014 · 3 comments

Comments

@avagin
Copy link
Contributor

avagin commented Apr 23, 2014

src/ct.c: In function ‘spawn_wait’:
src/ct.c:80:6: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result]
read(pipe[0], &ret, sizeof(ret));
^
src/ct.c: In function ‘spawn_wake’:
src/ct.c:87:7: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result]
write(pipe[1], &ret, sizeof(ret));
^
cc1: all warnings being treated as errors
make[1]: *** [src/ct.o] Error 1
make: *** [src/libct.so] Error 2
@xemul
Copy link
Owner

xemul commented Apr 23, 2014

Check for retcode is not required there actually. The read() will not read in pre-initialized variable. If write() fails, there's nothing to be done about it :)

@avagin
Copy link
Contributor Author

avagin commented Apr 23, 2014

Now we need to explain this to gcc.

@xemul
Copy link
Owner

xemul commented Apr 23, 2014

You're welcome ;)

xemul pushed a commit that referenced this issue Nov 26, 2014
Merge pull request #1 from xemul/master
3b90ebd 
Update from origin
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
ct: initialize exit_code
6a739c0 
CID 131309 (#1 of 1): Uninitialized scalar variable (UNINIT)
19. uninit_use: Using uninitialized value exit_code.
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
ct: don't leak a file descriptor
950995b 
CID 131307 (#1 of 1): Resource leak (RESOURCE_LEAK)
20. leaked_handle: Handle variable fd going out of scope leaks the handle.
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
security: don't leak a file descriptor
b1cc426 
CID 131305 (#1 of 1): Resource leak (RESOURCE_LEAK)
20. leaked_storage: Variable f going out of scope leaks the storage it points to.

CID 131304 (#1 of 1): Resource leak (RESOURCE_LEAK)
16. leaked_storage: Variable f going out of scope leaks the storage it points to.

CID 131302 (#1 of 1): Resource leak (RESOURCE_LEAK)
14. leaked_handle: Handle variable fd going out of scope leaks the handle.

CID 131301 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing a pointer that might be null f when calling fscanf
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
CID 131300 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
b9db482 
8. negative_returns: wait_sock is passed to a parameter that cannot be negative.
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
process: typo fix
4b32c2a 
CID 131308 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking p suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
vz: don't close a negative fd
a2a01bf 
CID 131298 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
9. negative_returns: wait_sock is passed to a parameter that cannot be negative.
xemul pushed a commit that referenced this issue Oct 22, 2015
@avagin
net_util: typo fix
7f89ef0 
CID 131296 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: goto free;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avagin @xemul