dialects: (builtin) shape for DenseIntORFPElementsAttr is always known (

#3534)

As they only work for ranked structures, the shape will always be not
None

xdsl/dialects/builtin.py

@@ -1733,9 +1733,7 @@ class DenseIntOrFPElementsAttr(TypedAttribute, ContainerType[AnyDenseElement]):
     data: ParameterDef[ArrayAttr[AnyIntegerAttr] | ArrayAttr[AnyFloatAttr]]
 
     # The type stores the shape data
-    def get_shape(self) -> tuple[int, ...] | None:
-        if isinstance(self.type, UnrankedTensorType):
-            return None
+    def get_shape(self) -> tuple[int, ...]:
         return self.type.get_shape()
 
     def get_element_type(self) -> IntegerType | IndexType | AnyFloat:
@@ -1744,8 +1742,6 @@ def get_element_type(self) -> IntegerType | IndexType | AnyFloat:
     @property
     def shape_is_complete(self) -> bool:
         shape = self.get_shape()
-        if shape is None or not len(shape):
-            return False
 
         n = 1
         for dim in shape:

xdsl/interpreters/builtin.py

@@ -94,4 +94,4 @@ def dense_int_or_fp_elements_value(
                 attr.get_element_type(), interpreter.index_bitwidth
             ),
         )
-        return ShapedArray(data_ptr, list(shape) if shape is not None else [])
+        return ShapedArray(data_ptr, list(shape))

xdsl/interpreters/ml_program.py

@@ -28,8 +28,6 @@ def run_global_load_constant(
         global_value = global_op.value
         assert isinstance(global_value, DenseIntOrFPElementsAttr)
         shape = global_value.get_shape()
-        if shape is None:
-            raise NotImplementedError()
         xtype = xtype_for_el_type(
             global_value.get_element_type(), interpreter.index_bitwidth
         )

xdsl/interpreters/onnx.py

@@ -145,7 +145,7 @@ def run_constant(
                 op.value.get_element_type(), interpreter.index_bitwidth
             ),
         )
-        return (ShapedArray(data_ptr, list(shape) if shape is not None else []),)
+        return (ShapedArray(data_ptr, list(shape)),)
 
     @impl(onnx.ReshapeOp)
     def run_reshape(