Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it is inaccurate to export the inventory with environment variables #108

Open
immarvin opened this issue Sep 4, 2018 · 3 comments
Open
Labels
question Further information is requested

Comments

@immarvin
Copy link
Contributor

immarvin commented Sep 4, 2018

We import an inventory with environment variables , then we expect we can get the updated inventory file with environment variables on export, we have implemented this. But in most of the time, the exported inventory is misleading, which does not exactly restore the inventory file imported.

I think we need to consider to export the raw inventory without any reverse environment substitution.

@immarvin immarvin added the question Further information is requested label Sep 4, 2018
@immarvin
Copy link
Contributor Author

immarvin commented Sep 4, 2018

@robin2008 @whowutwut @zet809 @xuweibj , any thoughts?

@zet809
Copy link

zet809 commented Sep 4, 2018

hi, @immarvin , can you give some example here? Do you mean the export inventory file failed to replace a string back to environment variable?

@robin2008
Copy link
Member

@immarvin here you mean to extra the variables from osimage definition in xcat DB?

Variables are normally used when applying the code pattern, aka import. In this case, the variables itself will be stored into source control too.

For export, I thought there might be two potential use cases:

  • export as backup/restore (No needs to do any special handling, keep it the same as it is imported)
  • export and publish to public hub for sharing (Maybe Admin decision to export which variables)

As the export case is very limited, need to dig out what's required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants