Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up "fungible" part with inventories #152

Open
domob1812 opened this issue Jul 14, 2020 · 1 comment
Open

Clean up "fungible" part with inventories #152

domob1812 opened this issue Jul 14, 2020 · 1 comment
Labels
cleanup Code cleanups / refactorings game Something related to the game logic interface Something related to the RPC (or other) interface

Comments

@domob1812
Copy link
Collaborator

All inventories, moves that touch items and game-state JSON representations include "fungible" somewhere in the format. This was introduced when we still planned to also have true non-fungible items, which would be separate. But now that all items in inventories will always be fungible (ERC-1155 style), we should clean this up at some point.
@domob1812 domob1812 added cleanup Code cleanups / refactorings game Something related to the game logic labels Jul 14, 2020
@domob1812
Copy link
Collaborator Author

As this affects the move format, it will be a consensus fork. It also affects the frontend, both for move generation and for retrieving the game state.

@domob1812 domob1812 added the interface Something related to the RPC (or other) interface label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanups / refactorings game Something related to the game logic interface Something related to the RPC (or other) interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domob1812