CP-52708: Avoid making Unix read/write calls for internal API calls: … #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forward the API call directly like we do with the CLI for calls to the coordinator when we are the coordinator Signed-off-by: Edwin Török <[email protected]>
psafont
reviewed
Dec 13, 2024
|
|
||
| let () = Unix.close dummy_fd | ||
|
|
||
| let fake_rpc2 req rpc = Api_server.Server.dispatch_call req dummy_fd2 rpc |
There was a problem hiding this comment.
This makes dummy_fd2 slot into the origin type of ocaml/xapi/context.ml, which needs to be handled by all of its user, like the preauth, _client_of_origin, parent_of_origin, and others.
This needs a closer look, I doubt it can work as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…forward the API call directly like we do with the CLI for calls to the coordinator when we are the coordinator
We might want to check that tracing still works with this, e.g. we might have to create a new span.
This avoids a lot of needless internal serialization, and a similar mechanism is already used by the CLI.