[Rgen] Add the missing code to complete the property datamodel in the transformer. #22094

mandel-macaque · 2025-02-01T11:44:15Z

Add the missing methods to be able to correctly parse a property and store it in the data model. This change adds support for Fields and Properties.

github-actions · 2025-02-01T11:48:25Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

samhouts

Seems straightforward. I see the new method, it makes sense, looks well-tested. Most of the other code changes appear to be moving around existing code.

src/rgen/Microsoft.Macios.Transformer/DataModel/Property.Transformer.cs

vs-mobiletools-engineering-service2 · 2025-02-01T23:15:43Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 529f2463516d3f0ff885447efa8b829f4886b91d [PR build]

… transformer. Add the missing methods to be able to correcly parse a property and store it in the data model. This change adds support for Fields and Properties.

vs-mobiletools-engineering-service2 · 2025-02-02T01:05:11Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:08:37Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:14:34Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:28:13Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:28:57Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:29:12Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:29:16Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T01:40:35Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-02T02:34:12Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ generator tests

1 tests failed, 4 tests passed.

Roslyn Transformer tests: TimedOut (Execution timed out after 10 minutes.)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 88267556d767de2f45244a1d61d1b47fc3c02527 [PR build]

This comment has been minimized.

Sign in to view

samhouts requested a review from Copilot February 1, 2025 16:00

Copilot AI reviewed Feb 1, 2025

View reviewed changes

samhouts approved these changes Feb 1, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Transformer/DataModel/Property.Transformer.cs Outdated Show resolved Hide resolved

samhouts changed the title ~~[Rgen] Add the missing code to complety the property datamodel in the transformer.~~ [Rgen] Add the missing code to complete the property datamodel in the transformer. Feb 1, 2025

dalexsoto approved these changes Feb 1, 2025

View reviewed changes

mandel-macaque force-pushed the dev/mandel/transformer-method-datamodel branch from e75c7ab to 63c51aa Compare February 1, 2025 18:35

Base automatically changed from dev/mandel/transformer-method-datamodel to main February 1, 2025 21:35

mandel-macaque force-pushed the dev/mandel/transformer-property-datamodel branch from 91e7e6c to 529f246 Compare February 1, 2025 21:42

This comment has been minimized.

Sign in to view

[Rgen] Add the missing code to complety the property datamodel in the…

8826755

… transformer. Add the missing methods to be able to correcly parse a property and store it in the data model. This change adds support for Fields and Properties.

mandel-macaque force-pushed the dev/mandel/transformer-property-datamodel branch from 503563e to 8826755 Compare February 1, 2025 23:57

[Rgen] Add the missing code to complete the property datamodel in the transformer. #22094

Are you sure you want to change the base?

[Rgen] Add the missing code to complete the property datamodel in the transformer. #22094

Conversation

mandel-macaque commented Feb 1, 2025 • edited by samhouts Loading

github-actions bot commented Feb 1, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

samhouts left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Windows Integration Tests passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 2, 2025

✅ [PR Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Feb 2, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Feb 2, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Feb 2, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Feb 2, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Feb 2, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Feb 2, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Feb 2, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Feb 2, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ generator tests

Successes

mandel-macaque commented Feb 1, 2025 •

edited by samhouts

Loading