Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow Disabling System Proxy in Requests #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dosine-staging[bot]
Copy link

This pull request addresses the issue where the requests library in a Windows environment was unable to bypass the system proxy settings when using PyCharm and JupyterLab. The problem was that setting proxies to None, {}, or "" did not prevent the use of the system proxy.

Changes Made:

  • Modified the merge_environment_settings method in sessions.py to ensure that when proxies is explicitly set to None, the environment proxies are not automatically applied.

Impact:

  • Users can now effectively bypass the system proxy by setting proxies to None, {}, or "" in their requests, allowing direct internet access without using the system proxy.

This fix resolves the issue reported in Task ID: I_kwDOABTKOs6UWlu5, ensuring that the requests library behaves as expected when users wish to disable proxy usage.


Created by Genie. You can follow its reasoning on Cosine

@dosine-staging dosine-staging bot marked this pull request as ready for review November 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant