Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incoming breaking change on Ledger #659

Open
adrienlacombe opened this issue Sep 26, 2024 · 6 comments
Open

incoming breaking change on Ledger #659

adrienlacombe opened this issue Sep 26, 2024 · 6 comments

Comments

@adrienlacombe
Copy link

gm @xJonathanLEI there is an incoming breaking change on Ledger side cf https://github.com/LedgerHQ/starknet-js-client/releases/tag/2.3.0 the release data is not know yet but ETA is 2 weeks.

@adrienlacombe
Copy link
Author

@adrienlacombe
Copy link
Author

ETA is next week, deploy account txs will also be clear signed

@xJonathanLEI
Copy link
Owner

Hi @adrienlacombe thanks for reporting. Is there any information on which specific commit in LedgerHQ/app-starknet is aiming to be released? I need to build from source to be able to test.

@adrienlacombe
Copy link
Author

Hi @adrienlacombe thanks for reporting. Is there any information on which specific commit in LedgerHQ/app-starknet is aiming to be released? I need to build from source to be able to test.

not yet but I expect to have it this week so I keep you posted @xJonathanLEI thank you!

@xJonathanLEI
Copy link
Owner

Got it. Will just assume the latest commit for now.

@adrienlacombe
Copy link
Author

Got it. Will just assume the latest commit for now.

you can, the only expected change is clear signing of deploy account txs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants