Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDC: Contract deployment selector mismatch #610

Open
FabijanC opened this issue Jun 19, 2024 · 1 comment
Open

UDC: Contract deployment selector mismatch #610

FabijanC opened this issue Jun 19, 2024 · 1 comment

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Jun 19, 2024

Currently starknet.rs uses deployContract (camelCase):

/// Selector for entrypoint `deployContract`.
const SELECTOR_DEPLOYCONTRACT: Felt = Felt::from_raw([

OpenZeppelin has been using deploy_contract (snake_case) as the UDC method name since v0.11.0:
https://github.com/OpenZeppelin/cairo-contracts/blob/a83f36b23f1af6e160288962be4a2701c3ecbcda/src/presets/universal_deployer.cairo#L38

Should someone change something?

@xJonathanLEI
Copy link
Owner

The new universal deployer contract is a completely different implementation that uses Poseidon hash instead of Pedersen. So no, we should not change this.

Whether we should support the new deployer contract is another question. I don't really see the point though? It does the same thing as the old one as is probably not widely deployed. I mean on the other hand the old one's address is pretty much hard-coded to every single piece of tooling in the ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants