Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Refactor custom_seasons to use Xarray's SeasonGrouper() API [WIP] #714

Open
tomvothecoder opened this issue Nov 14, 2024 · 0 comments · May be fixed by #715
Open

[Enhancement]: Refactor custom_seasons to use Xarray's SeasonGrouper() API [WIP] #714

tomvothecoder opened this issue Nov 14, 2024 · 0 comments · May be fixed by #715
Assignees
@tomvothecoder
Labels
type: enhancement New enhancement request

Comments

@tomvothecoder
Copy link
Collaborator

Is your feature request related to a problem?

The current custom_seasons back-end uses Pandas DataFrames to store Datetime components, which then get manipulated downstream (e.g., shifting months for spanning calendar years, dropping incomplete seasons).

Describe the solution you'd like

In Xarray PR #9524, the SeasonGrouper() API will introduce:

  • groupby() custom seasons
  • support seasons that span the calendar year (uses previous year for correct grouping)
  • drop_incomplete to drop incomplete seasons

Describe alternatives you've considered

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomvothecoder tomvothecoder

Labels
type: enhancement New enhancement request
Projects
xCDAT Development
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial prototype to refactor custom_seasons API with Xarray SeasonGrouper() API [WIP] xCDAT/xcdat
1 participant
@tomvothecoder