Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OPeNDAP datasets with Xarray tutorial datasets in docs #705

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Oct 3, 2024

Description

Notebooks

  • climatology-and-departures.ipynb -- this one might need extra review for the plots
  • general-utilities.ipynb
  • introduction-to-xcdat.ipynb
  • parallel-computing-with-dask.ipynb
  • regridding-horizontal.ipynb
    • Might need to create dummy data for this one.
  • regridding-vertical.ipynb
    • Might need to create dummy data for this one.
  • spatial-average.ipynb
  • temporal-average.ipynb

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the title Replace OPeNDAP datasets with Xarray tutorial datasets Replace OPeNDAP datasets with Xarray tutorial datasets in docs Oct 3, 2024
@tomvothecoder tomvothecoder self-assigned this Oct 3, 2024
@github-actions github-actions bot added the type: docs Updates to documentation label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.68%. Comparing base (1cfd369) to head (92204be).

Files with missing lines Patch % Lines
xcdat/tutorial.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #705      +/-   ##
===========================================
- Coverage   100.00%   99.68%   -0.32%     
===========================================
  Files           15       16       +1     
  Lines         1555     1568      +13     
===========================================
+ Hits          1555     1563       +8     
- Misses           0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation
Projects
Status: In Progress
1 participant