Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XbimCompund. InitFaces. Catch Standard_Failure instead of std::except… #448

Closed
wants to merge 4 commits into from
Closed

XbimCompund. InitFaces. Catch Standard_Failure instead of std::except… #448

wants to merge 4 commits into from

Conversation

santiagoIT
Copy link

XbimWire::NormalDir throws a Standard_Failure.

In XbimCompound::InitFaces a Standard_Failure needs to be caught. Not a std::exception.

This led to the exception not being caught and the program crashing.

If you need, I can send you an IFC file that you can use to reproduce the problem.
Remark for me in case you want the Ifc file: HSB-19279

@hsbSantiago
XbimCompund. InitFaces. Catch Standard_Failure instead of std::except…
9093d8b 
…ion. XbimWire::NormalDir throws a Standard_Failure.
@santiagoIT
Copy link
Author

The checks for the pull request have failed, but they seem to have nothing to do with my change:

Error C1088: Cannot flush compiler intermediate file

@andyward
Copy link
Member

Thanks for the work on this - checks have passed now. Will just check over and merge

@hsbSantiago
XbimCompund. InitFaces. check if outer normal consists of NAN. Can ha…
477172e 
…ppen in optimized Release builds, which will then result in program crashing with a stack overflow exception
@santiagoIT
Copy link
Author

I have added a new commit. There is a difference between DEBUG and optimized RELEASE builds.
The first commit solves the problem in DEBUG builds. But in release builds the outernormal sometimes contained NAN doubles which then led the program to crash later on with stack overflow exceptions.

@CCT-Mukund-Thakare
Copy link

@santiagoIT
Have you done local development environment setup for xbim ?
How are visualizing the fixed bug's ?
I am looking for local development environment set up documentation.

#464

daniilch added 2 commits June 4, 2024 09:53
Added test on trimmed curve creation
b72f0e6 
# Conflicts:
#	Xbim.Geometry.Engine.Interop.Tests/GithubIssuesTests.cs
#	Xbim.Geometry.Engine.Interop.Tests/Xbim.Geometry.Engine.Interop.Tests.csproj
Fixed XbimCurve geometry construction for trimmed ellipse
1e672a9
@santiagoIT
Copy link
Author

I see the fixes have already been added to the code. I will close this pull request

@santiagoIT santiagoIT closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin1cerny martin1cerny Awaiting requested review from martin1cerny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@santiagoIT @andyward @CCT-Mukund-Thakare @hsbSantiago